Feature #727
Indent messages across newlines
Status: | Closed | Start: | 06/27/2012 | |
Priority: | Normal | Due date: | ||
Assigned to: | Mirco Bauer | % Done: | 100% |
|
Category: | Frontend GNOME | |||
Target version: | 0.8.10 | |||
Complexity: | High |
|||
Votes: | 0 |
Description
If a message is too long to fit into a single line, it will be wrapped to a 2nd line. The issue is that 2nd line doesn't align with the 1st line. Smuxi should align wrapped messages.
Associated revisions
Revision b9e66dd0dd06240a8bbb342351239eb4a6f09efd
[Frontend-GNOME] Indent multi-line messages and events (closes: #727)
History
Updated by Mirco Bauer 4560 days ago
The Gtk.TextView has Gtk.TextTags which allow to individually set indention width (see http://developer.gnome.org/gtk/2.24/GtkTextTag.html#GtkTextTag--indent). This is important as each message has a different sized "prefix" which is the sender nick usually. The issue is though that the MessageModel makes no distinction between the sender prefix and the actually message, so the GNOME frontend doesn't know how to obtain the right indent width from the MessageModel.
Updated by Mirco Bauer 4560 days ago
Either the MessageModel needs to be extended with an IdentMessagePart to hint the frontend or by separating the sender from the message itself. Either way, this would be a breakage of the 0.8 protocol! :(
Updated by Mirco Bauer 4559 days ago
- Target version set to 0.8.10
Updated by Mirco Bauer 4559 days ago
For now a hack was used to extract the nick from the message (using a regex)
Updated by Mirco Bauer 4559 days ago
- Status changed from New to Closed
- % Done changed from 0 to 100
Applied in changeset b9e66dd0dd06240a8bbb342351239eb4a6f09efd.