Bug #549

avatar

Cannot configure/connect to an IRC server with SSL on a port other than 6697 via GUI

Added by Jo Shields 2316 days ago. Updated 2293 days ago.

Status:Closed Start:11/25/2010
Priority:Normal Due date:
Assigned to:avatarJo Shields % Done:

100%

Category:Engine IRC
Target version:0.8.9
Complexity:

Low

Found in Version:

Votes: 0

Description

It is not possible to connect to an IRC server using SSL unless it's on port 6697.

This is because the port number is overwritten with 6697 whenever the f_UseEncryptionCheckButton.Clicked event is called - and this event is called whenever f_ValidateServerCertificateCheckButton is set to Active (GTK ToggleButton Toggled signals are triggered by gtk_toggle_button_set_active). So when the server configuration is loaded from the backend config file, the port is set to the value in the file, then overwritten with 6697 if SSL is enabled.

The attached patch fixes this, by setting the port number AFTER reading the SSL state from the config file - so 6697 is set, then overwritten by the config file value.

fix_ssl_irc_on_nonstandard_ports.patch (1.1 KB) Jo Shields, 11/25/2010 01:12 PM


Related issues

duplicated by Smuxi - Bug #544 Connecting via SSL does not work Closed 11/08/2010

Associated revisions

Revision 561f605b124ebdb1473136b883d892c3a29def73
Added by Jo Shields 2293 days ago

Fixed connecting to an IRC server with SSL on a port other than 6697 via GUI (closes: #549)

It is not possible to connect to an IRC server using SSL unless it's on
port 6697.

This is because the port number is overwritten with 6697 whenever the
f_UseEncryptionCheckButton.Clicked event is called - and this event is called
whenever f_ValidateServerCertificateCheckButton is set to Active (GTK
ToggleButton Toggled signals are triggered by gtk_toggle_button_set_active).
So when the server configuration is loaded from the backend config file, the
port is set to the value in the file, then overwritten with 6697 if SSL is
enabled.

This patch fixes this, by setting the port number AFTER reading the SSL state
from the config file - so 6697 is set, then overwritten by the config file
value.

History

Updated by Mirco Bauer 2312 days ago

avatar
  • Assigned to changed from Mirco Bauer to Jo Shields

Updated by Mirco Bauer 2312 days ago

avatar
  • Status changed from New to Resolved
  • Target version set to 0.8.9

Merge is pending

Updated by Jo Shields 2293 days ago

avatar
  • Status changed from Resolved to Closed

Also available in: Atom PDF