Feature #270
Find Group Chat should show colored IRC topics
Status: | Closed | Start: | 01/04/2010 | |
Priority: | Low | Due date: | 01/07/2010 | |
Assigned to: | David Paleino | % Done: | 100% |
|
Category: | Frontend GNOME | |||
Target version: | 0.7 | |||
Complexity: | Medium |
|||
Votes: | 0 |
Description
If you search for IRC channels, often (depending on the IRC network) the topic contain color and other formatting information. This information is available in an objec-tree (MessageModel) but is not used yet (converted to GTK+) in FindGroupChatDialog.OnFindButtonClicked().
Related issues
blocks Smuxi - Task #280 | Provide testcase for Smuxi.Frontend.GNOME.PangoTools | Closed | 01/07/2010 |
Associated revisions
Revision 09b2f31214fc59e19ba942a65d770140fb8154c1
Show color and formattings of topics in FindGroupChatDialog (closes: #270)
- Implemented Pango markup converter of a MessageModel
- Use Pango markup within the FindGroupChatDialog for topics
Signed-off-by: Mirco Bauer <meebey@meebey.net>
History
Updated by Mirco Bauer 5434 days ago
- Complexity set to Medium
Updated by Mirco Bauer 5432 days ago
- Priority changed from Normal to Low
Updated by David Paleino 5432 days ago
- % Done changed from 0 to 90
The feature has been implemented, I'm only getting a tons of:
(smuxi-frontend-gnome:10651): GLib-GObject-WARNING **: unable to set property `text' of type `gchararray' from value of type `GtkSharpValue'
in the console.
I suppose this is due to the fact that I'm using a Gtk.CellRendererText(), but I'm passing a MessageModel. The renderer then expects a string -- translated in C that means a "gchararray", while MessageModel probably gets translated to a generic "GtkSharpValue".
I don't think this is easily fixable in any way, but I'm not setting this to 100% until I'm totally sure.
Updated by David Paleino 5432 days ago
- % Done changed from 90 to 100
Fixed the warnings too. WOOO \o/
Updated by David Paleino 5432 days ago
- Due date set to 01/07/2010
- 1 set to fixed
Repository: git://gitorious.org/~dpaleino/smuxi/dpaleino-smuxi.git
Branch: feature/#270-FindGroupChat_should_show_colored_IRC_topics
Updated by David Paleino 5432 days ago
- Status changed from New to Closed
Applied in changeset 09b2f31214fc59e19ba942a65d770140fb8154c1.