Bug #261
Closing a channel tab shows ErrorNotOnChannel
| Status: | Closed | Start: | 12/31/2009 | |
| Priority: | Normal | Due date: | ||
| Assigned to: |  Mirco Bauer |
% Done: | 100% |
|
| Category: | Frontend GNOME | |||
| Target version: | 0.7 | |||
| Complexity: | Found in Version: | |||
| Votes: | 0 |
Description
If you leave a channel using the tab context menu -> close seems to try to leave the channel two times resulting in this error on the server tab:
05:39 [442 (ErrorNotOnChannel) #smuxi] You're not on that channel
2009-12-31 05:39:02,296 [Main] DEBUG TRACE - [smuxi-frontend-gnome.exe] ChatView.OnTabMenuCloseActivated(sender = Gtk.ImageMenuItem, e = System.EventArgs) 2009-12-31 05:39:02,296 [Main] DEBUG TRACE - [smuxi-frontend-gnome-irc.dll] IrcGroupChatView.Close() 2009-12-31 05:39:02,296 [Main] DEBUG TRACE - [smuxi-frontend-gnome.exe] ChatView.Close() 2009-12-31 05:39:02,296 [Main] DEBUG TRACE - [smuxi-engine-irc.dll] IrcProtocolManager.CloseChat(fm = Smuxi.Engine.FrontendManager, chat = <IRC irc.oftc.net:6667/#smuxi>) 2009-12-31 05:39:02,296 [Main] DEBUG TRACE - [smuxi-engine.dll] CommandModel..ctor(fm = Smuxi.Engine.FrontendManager, chat = 'Smuxi.Engine.ProtocolChatModel', cmdChar = '/', data = '/cmd #smuxi') 2009-12-31 05:39:02,296 [Main] DEBUG TRACE - [smuxi-engine.dll] CommandModel..ctor(fm = Smuxi.Engine.FrontendManager, chat = 'Smuxi.Engine.GroupChatModel', cmdChar = '/', data = '/cmd #smuxi') 2009-12-31 05:39:02,298 [Main] DEBUG TRACE - [smuxi-frontend-gnome.exe] MainWindow.OnFocusInEvent(sender = Smuxi.Frontend.Gnome.MainWindow, e = Gtk.FocusInEventArgs) 2009-12-31 05:39:02,419 [WriteThread (irc.oftc.net:6667)] DEBUG SOCKET - sent: "PART #smuxi" 2009-12-31 05:39:02,439 [ReadThread (irc.oftc.net:6667)] DEBUG SOCKET - received: ":meebey!~meebey@188-192-43-123-dynip.superkabel.de PART #smuxi" 2009-12-31 05:39:02,446 [IrcProtocolManager (irc.oftc.net:6667) listener] DEBUG QUEUE - read: ":meebey!~meebey@188-192-43-123-dynip.superkabel.de PART #smuxi" 2009-12-31 05:39:02,446 [IrcProtocolManager (irc.oftc.net:6667) listener] DEBUG MESSAGEPARSER - IrcMessageData nick: 'meebey' ident: '~meebey' host: '188-192-43-123-dynip.superkabel.de' type: 'Part' from: 'meebey!~meebey@188-192-43-123-dynip.superkabel.de' channel: '#smuxi' message: '' 2009-12-31 05:39:02,446 [IrcProtocolManager (irc.oftc.net:6667) listener] DEBUG CHANNELSYNCING - parting channel: #smuxi 2009-12-31 05:39:02,446 [IrcProtocolManager (irc.oftc.net:6667) listener] DEBUG Smuxi.Engine.IrcProtocolManager - _OnPart() e.Channel: #smuxi e.Who: meebey 2009-12-31 05:39:02,446 [IrcProtocolManager (irc.oftc.net:6667) listener] DEBUG TRACE - [smuxi-engine.dll] Session.RemoveChat(chat = <IRC irc.oftc.net:6667/#smuxi>) 2009-12-31 05:39:02,447 [Main] DEBUG TRACE - [smuxi-frontend-gnome.exe] Notebook._OnSwitchPage(sender = Smuxi.Frontend.Gnome.Notebook, e = Gtk.SwitchPageArgs) 2009-12-31 05:39:02,447 [Main] DEBUG TRACE - [smuxi-frontend-gnome.exe] MainWindow.OnNotebookSwitchPage(sender = Smuxi.Frontend.Gnome.Notebook, e = Gtk.SwitchPageArgs) 2009-12-31 05:39:02,448 [Main] DEBUG TRACE - [smuxi-frontend-gnome.exe] MainWindow.OnChatViewManagerChatRemoved(sender = Smuxi.Frontend.Gnome.ChatViewManager, e = Smuxi.Frontend.Gnome.ChatViewManagerChatRemovedEventArgs) 2009-12-31 05:39:02,619 [WriteThread (irc.oftc.net:6667)] DEBUG SOCKET - sent: "PART #smuxi" 2009-12-31 05:39:02,639 [ReadThread (irc.oftc.net:6667)] DEBUG SOCKET - received: ":reticulum.oftc.net 442 meebey #smuxi :You're not on that channel"
Associated revisions
Revision 9dc69c4caa22f7f97bdfc5180434439b7b765bee
Fixed leaving an IRC channel two times if the tab close button was used, as the base implementation of Close() handles this already. (closes: #261)
History
Updated by Mirco Bauer 5469 days ago
- Status changed from New to Closed
- % Done changed from 0 to 100
Applied in changeset 9dc69c4caa22f7f97bdfc5180434439b7b765bee.