Smuxi

--add-user --user=meebey --password=foobar

--modify-user --user=meebey --password=barfoo

--delete-user --user=meebey

The following changes since commit a5cd8f7ffaf48143cc96258b372ab4a6306dda37:
Mirco Bauer (1):
Only wait for pending channel joins if there is actually one happening and not for failed attempts for example. (closes: #251)

are available in the git repository at:

git://moonpyk.ath.cx/smuxi.git feature/#235_Smuxi_Server_Manager

Clement Bourgeois (1):
Implemented Feature #235 - Smuxi Server Manager (closes: #235)

src/Common/Common.mdp                           |    5 +-

src/Common/Makefile.am                          |    1 +

src/Common/NDesk.Options.cs                     | 1100 +++++++++++++++++++++

src/Engine/Config/UserListController.cs         |   99 ++

src/Engine/Engine.mdp                           |    1 +

src/Engine/Makefile.am                          |    1 +

src/Frontend-GNOME/Views/Chats/GroupChatView.cs |    2 +

src/Server/Main.cs                              |  185 ++-

8 files changed, 1368 insertions(+), 26 deletions(-)

create mode 100644 src/Common/NDesk.Options.cs

create mode 100644 src/Engine/Config/UserListController.cs

Here some comments regarding the changeset:

+            if(addUser || modUser) {

+            } catch(OptionException) {}

+            } else if(delUser) {

+        private static void _ManageUsers (bool addUser, bool delUser, bool modUser, string username, string password)

Ok, thats was all about Coding Standards. Now implementation comments:

+                    } catch(ArgumentException) {
+                        Console.WriteLine(
+                             "Error : Unable to add user \"$name\", it allready exists ! Did you mean -m|--modify-user ?" 
+                                   .Replace("$name", username)
+                        );

Don't make such assumptions when dealing with exception types. If you expect an error (like in this case) and want to handle it, let the layer below report what the issue was. For instance:
+ } catch (ArgumentException ex) {
+ Console.WriteLine("Unable to add user '{0}', error: {1}", username, ex.Message);

For all messages you need to use _() to mark it as translatable, if you need to combine it with variables use String.Format() around it.

In UserListController don't call for all operations Save(), the caller of that has to decide it if it's persistent or not. Simply call config.Save() at the end of _ManageUsers() if something was changed.

    GroupChatView.cs : fixed a unprotected _Logger call that lead to compile
    fail in release mode (#if LOG4NET missing)

Ok thats all for now, it looks pretty good!

Please address the issues from above and tell me when you pushed a new version.

Please merge git://moonpyk.ath.cx/smuxi.git -> feature/#235_Smuxi_Server_Manager

It makes now use of Console.Writeline() format, fixes a missing _() of previous commit.

I modified POTFILES.in too to include new files were translatable strings are now present.

Applied in changeset 32ed9a57f3411d05e2a040ff7bf6aa21f1cb759d.